Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added update test #24

Merged
merged 32 commits into from Feb 2, 2020
Merged

Added update test #24

merged 32 commits into from Feb 2, 2020

Conversation

@flabbet
Copy link
Contributor

flabbet commented Feb 2, 2020

Salvaged and fixed from #15. Still not whole update is tested, but it won't be hard to add it later

flabbet added 29 commits Jan 22, 2020
Added pip3 install codecov
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Feb 2, 2020

Hello @flabbet! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-02-02 19:15:07 UTC
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 2, 2020

Codecov Report

Merging #24 into master will increase coverage by 1.83%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   55.39%   57.22%   +1.83%     
==========================================
  Files           3        3              
  Lines         343      353      +10     
  Branches       46       47       +1     
==========================================
+ Hits          190      202      +12     
+ Misses        146      142       -4     
- Partials        7        9       +2
Impacted Files Coverage Δ
swaglyrics_backend/issue_maker.py 58.94% <7.69%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c82795...5307609. Read the comment docs.

flabbet added 3 commits Feb 2, 2020
@aadibajpai aadibajpai merged commit e88d554 into SwagLyrics:master Feb 2, 2020
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 7.69% of diff hit (target 55.39%)
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 57.22% (+1.83%) compared to 7c82795
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.