Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Match and Team Number to Data Entry Title #55

Merged
merged 2 commits into from Feb 20, 2018
Merged

Add Match and Team Number to Data Entry Title #55

merged 2 commits into from Feb 20, 2018

Conversation

pr1sm
Copy link
Contributor

@pr1sm pr1sm commented Feb 19, 2018

Problem

The title for the Data Entry view only displayed "Data Entry" which did not include any information about the team or match.

Solution

Change the title to include the Match and Team numbers. The new titles looks like this:
simulator screen shot - ipad air - 2018-02-19 at 01 26 20

Issues Fixed

Resolve #51

Checks

  • App builds and runs
  • Title for Data Entry matches the correct team and match numbers.

This commit adds the Match and Team number as the title for the Data Entry View. The format matches the Results view.

Issue: #51
@pr1sm
Copy link
Contributor Author

pr1sm commented Feb 19, 2018

This title matches the Results View, but I'm wondering if we want to have the alliance in the title? Let me know if this is preferable, I will wait to merge this.

@pr1sm
Copy link
Contributor Author

pr1sm commented Feb 20, 2018

+1, ready for merge

@pr1sm pr1sm merged commit 73aa5e5 into master Feb 20, 2018
@pr1sm pr1sm deleted the issue_51 branch March 2, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant