test: link to externals outside node_modules #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm working on a fix, so lmk if you are too. ;) |
aleclarson
added a commit
to aleclarson/rollup-plugin-dts
that referenced
this pull request
Oct 29, 2020
|
Okay, I've got a fix working! LGTM 👍 |
In this test, the `node_modules/d3-drag` path is linked to `../../d3-drag` (which is a local package, not from node_modules). This setup mimics a monorepo, where dependencies often point to local packages. The local `d3-drag` package contains an `index.d.ts` module. This test fails with `Unexpected token` error, since no `Program` is found for the `d3-drag/index.d.ts` module.
aleclarson
added a commit
to aleclarson/rollup-plugin-dts
that referenced
this pull request
Oct 29, 2020
Swatinem
reviewed
Oct 29, 2020
| @@ -0,0 +1 @@ | |||
| ../../../d3-drag | |||
There was a problem hiding this comment.
any specific reason for this link? I would rather like to keep the testcase self contained.
There was a problem hiding this comment.
lol nevermind, I should have read the PR description, lol.
There was a problem hiding this comment.
unfortunately, it has to exist outside the root directory of the test case for the error to occur :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this test, the
node_modules/d3-dragpath is linked to../../d3-drag(which is a local package, not from node_modules).This setup mimics a monorepo, where dependencies often point to local packages.
The local
d3-dragpackage contains anindex.d.tsmodule.This test fails with
Unexpected tokenerror, since noProgramis found for thed3-drag/index.d.tsmodule.