Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prefix-key cache-directories and cache-targets options #85

Merged
merged 4 commits into from
Oct 18, 2022

Conversation

mkatychev
Copy link
Contributor

@mkatychev mkatychev commented Oct 17, 2022

rust-cache currently stores a target directory even if a shared compilation cache such as sccache is used.

Added prefix-key cache-directories and cache-targets options allows more control over what compilation artifacts to cache.

Copy link
Owner

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

README.md Outdated
Comment on lines 21 to 23
# An additional cache key that is stable over multiple jobs
# that is used instead of the automatic `job`-based
# cache key and is thus stable across jobs.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this now repeats "stable over multiple jobs" / "stable across jobs"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will just mirror what is in action.yml

README.md Outdated Show resolved Hide resolved
mkatychev and others added 2 commits October 18, 2022 15:15
Co-authored-by: Arpad Borsos <swatinem@swatinem.de>
@Swatinem Swatinem merged commit b8e72aa into Swatinem:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants