From d8b19900d5ef9c297139f2702d53f79997a933e2 Mon Sep 17 00:00:00 2001 From: Maksim Mrug <80621719+kruzhambus@users.noreply.github.com> Date: Thu, 20 Jul 2023 14:54:05 +0300 Subject: [PATCH 1/3] fast fix --- apps/production/src/project/dto/project.dto.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/production/src/project/dto/project.dto.ts b/apps/production/src/project/dto/project.dto.ts index 38f36e056..5dc8fb11c 100644 --- a/apps/production/src/project/dto/project.dto.ts +++ b/apps/production/src/project/dto/project.dto.ts @@ -38,6 +38,7 @@ export class ProjectDTO { description: "The project's state. If enabled - all the incoming analytics data will be saved.", }) + @IsNotEmpty() active: boolean @ApiProperty({ From 814a1f96431ee91e3859ecf31595ebb25b44e786 Mon Sep 17 00:00:00 2001 From: Maksim Mrug <80621719+kruzhambus@users.noreply.github.com> Date: Thu, 20 Jul 2023 15:00:06 +0300 Subject: [PATCH 2/3] some improvments --- apps/production/src/project/dto/project.dto.ts | 1 - .../src/project/dto/update-project.dto.ts | 13 +++++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/apps/production/src/project/dto/project.dto.ts b/apps/production/src/project/dto/project.dto.ts index 5dc8fb11c..38f36e056 100644 --- a/apps/production/src/project/dto/project.dto.ts +++ b/apps/production/src/project/dto/project.dto.ts @@ -38,7 +38,6 @@ export class ProjectDTO { description: "The project's state. If enabled - all the incoming analytics data will be saved.", }) - @IsNotEmpty() active: boolean @ApiProperty({ diff --git a/apps/production/src/project/dto/update-project.dto.ts b/apps/production/src/project/dto/update-project.dto.ts index 5b92796b4..65fb1d5d6 100644 --- a/apps/production/src/project/dto/update-project.dto.ts +++ b/apps/production/src/project/dto/update-project.dto.ts @@ -1,4 +1,6 @@ import { IntersectionType, PickType } from '@nestjs/mapped-types' +import { IsNotEmpty } from 'class-validator' +import { ApiProperty } from '@nestjs/swagger' import { ProjectDTO } from './project.dto' import { ProjectPasswordDto } from './project-password.dto' @@ -8,9 +10,16 @@ export class UpdateProjectDto extends IntersectionType( 'name', 'origins', 'ipBlacklist', - 'active', 'public', 'isCaptcha', ] as const), ProjectPasswordDto, -) {} +) { + @ApiProperty({ + required: false, + description: + "The project's state. If enabled - all the incoming analytics data will be saved.", + }) + @IsNotEmpty() + active: boolean +} From f70c951e5106e9c97f7990c3d131735f1c8ff2e7 Mon Sep 17 00:00:00 2001 From: Maksim Mrug <80621719+kruzhambus@users.noreply.github.com> Date: Thu, 20 Jul 2023 15:02:24 +0300 Subject: [PATCH 3/3] some improvments --- apps/production/src/project/dto/update-project.dto.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/apps/production/src/project/dto/update-project.dto.ts b/apps/production/src/project/dto/update-project.dto.ts index 65fb1d5d6..da20d1051 100644 --- a/apps/production/src/project/dto/update-project.dto.ts +++ b/apps/production/src/project/dto/update-project.dto.ts @@ -10,16 +10,23 @@ export class UpdateProjectDto extends IntersectionType( 'name', 'origins', 'ipBlacklist', - 'public', 'isCaptcha', ] as const), ProjectPasswordDto, ) { @ApiProperty({ - required: false, + required: true, description: "The project's state. If enabled - all the incoming analytics data will be saved.", }) @IsNotEmpty() active: boolean + + @ApiProperty({ + required: true, + description: + "When true, anyone on the internet (including Google) would be able to see the project's Dashboard.", + }) + @IsNotEmpty() + public: boolean }