Convert context testing format from PLIST to YAML #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well we could generate YAML, by using YAMS which we already use for config file 😉 |
|
Which is better though in this case? I don't have a preference either way. |
|
Keep in mind that we may want to open up this context interface at some point, and JSON is much easier to use in general than YAML (which often needs an extra library to support it). |
|
And I know that YAML is a superset of JSON 😉 |
AliSoftware
approved these changes
Apr 29, 2018
|
Actually, I just proved your point I think? 🤦♂️ |
|
Well json is fine too, I was mainly trolling about your "it's not possible to use YAML" 😅. As you wish; anything is better than plist anyway |
djbe
force-pushed
the
feature/json-contexts
branch
from
bd179e7
to
bfdee66
Compare
djbe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399.
Old note:
While YAML might be more powerful and allowing us to have much more compact contexts (using anchors and aliases), such contexts would have to be made by hand, they can't be generated automatically (as they are right now).