Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringIndex package #726

Merged
merged 1 commit into from Oct 25, 2020
Merged

StringIndex package #726

merged 1 commit into from Oct 25, 2020

Conversation

johnno1962
Copy link
Contributor

Hi Dave,

The package(s) being submitted are:

Checklist

I have either:

  • Run swift ./validate.swift. (does not run on Mojave)

Or, checked that:

  • The package repositories are publicly accessible.
  • The packages all contain a Package.swift file in the root folder.
  • The packages are written in Swift 4.0 or later.
  • The packages all contain at least one product (either library or executable).
  • The packages all have at least one release tagged as a semantic version.
  • The packages all output valid JSON from swift package dump-package with the latest Swift toolchain.
  • The package URLs are all fully specified including https and the .git extension.
  • The packages all compile without errors.

@johnno1962 johnno1962 closed this Oct 24, 2020
@daveverwer
Copy link
Member

Hey John, did you change your mind? We'd love to have the package, if you'd like it included!

@johnno1962 johnno1962 reopened this Oct 25, 2020
@johnno1962
Copy link
Contributor Author

Hi Dave, I couldn't get past validation or see what the error was. Am I holding it wrong?

No newline required?

Fix order
@daveverwer
Copy link
Member

I think the original problem was just that the JSON wasn't sorted. I see you've fixed it now though. Thanks for the submission.

@daveverwer daveverwer merged commit 45b7d87 into SwiftPackageIndex:main Oct 25, 2020
@johnno1962
Copy link
Contributor Author

Thanks Dave, I was holding it wrong after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants