add test target to package score #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndichin
force-pushed
the
add-test-target-count-to-score
branch
2 times, most recently
from
9092d39
to
e283390
Compare
cyndichin
force-pushed
the
add-test-target-count-to-score
branch
2 times, most recently
from
0640322
to
7783278
Compare
daveverwer
reviewed
Sep 5, 2023
cyndichin
force-pushed
the
add-test-target-count-to-score
branch
2 times, most recently
from
3c058a9
to
3537f01
Compare
cyndichin
force-pushed
the
add-test-target-count-to-score
branch
from
a72c3c7
to
03865dc
Compare
daveverwer
approved these changes
Sep 19, 2023
Tests/AppTests/ScoreTests.swift
Outdated
Comment on lines
174
to
193
| XCTAssertEqual(Score.compute(.init(licenseKind: .compatibleWithAppStore, | ||
| releaseCount: 20, | ||
| likeCount: 20_000, | ||
| isArchived: false, | ||
| numberOfDependencies: 2, | ||
| lastActivityAt: Current.date().adding(days: -10), | ||
| hasDocumentation: false, | ||
| numberOfContributors: 0, | ||
| hasTestTargets: false)), | ||
| 107) | ||
| XCTAssertEqual(Score.compute(.init(licenseKind: .compatibleWithAppStore, | ||
| releaseCount: 20, | ||
| likeCount: 20_000, | ||
| isArchived: false, | ||
| numberOfDependencies: 2, | ||
| lastActivityAt: Current.date().adding(days: -10), | ||
| hasDocumentation: false, | ||
| numberOfContributors: 0, | ||
| hasTestTargets: true)), | ||
| 122) |
There was a problem hiding this comment.
These tests will need fixing up to match the new scoring.
update score from `15` to `5` Co-authored-by: Dave Verwer <dave.verwer@gmail.com>
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #317
Discussed with @daveverwer