Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isValidFileUrl string extension #175

merged 1 commit into from May 27, 2017


None yet
2 participants
Copy link

LucianoPAlmeida commented May 27, 2017


  • I checked the Contributing Guidelines before creating this request.
  • I have only one commit in this pull request.
  • New extensions support iOS 8 or later.
  • New extensions are written in Swift 3.
  • I have added tests for new extensions, and they passed.
  • Pull request was created to master head branch.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All comments headers have the word SwifterSwift: before description.

This comment has been minimized.

Copy link

codecov bot commented May 27, 2017

Codecov Report

Merging #175 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
+ Coverage   92.17%   92.18%   +<.01%     
  Files          85       85              
  Lines        4730     4736       +6     
+ Hits         4360     4366       +6     
  Misses        370      370
Impacted Files Coverage Δ
...ests/SwifterSwiftTests/StringExtensionsTests.swift 100% <100%> (ø) ⬆️
Source/Extensions/StringExtensions.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f401fb8...ea2c0c1. Read the comment docs.

@omaralbeik omaralbeik merged commit 5dc9fcb into SwifterSwift:master May 27, 2017

3 checks passed

codecov/patch 100% of diff hit (target 92.17%)
codecov/project 92.18% (+<.01%) compared to f401fb8
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.