Add isBetween method to date extension #248
Conversation
| /// - Parameter endDate: endDate date to compare self to. | ||
| /// - Parameter includeBounds: true if the start and end date should be included (default is true) | ||
| /// - Returns: true if the date is between the two given dates. | ||
| public func isBetween(_ startDate: Date, _ endDate: Date, includeBounds: Bool = true) -> Bool { |
There was a problem hiding this comment.
I'm fine with this. Clean & well documented 🎉 I'm just curious if we don't need the extension and can use:
let date1 = Date()
let date2 = Date()
let date3 = Date()
let bool = (date1...date2).contains(date3)I agree having the bounds check makes this easier though. I would like to see it default to false though. Because between is technically not inclusive. What do you think @Bennx?
There was a problem hiding this comment.
@SD10 Of cause it does make more sense to have it set to false.
There was a problem hiding this comment.
I also like the Range idea. Lets see if i can figure that out.
There was a problem hiding this comment.
@Bennx The implementation doesn't need to be changed. It's fine as is. This could be more performant actually.
There was a problem hiding this comment.
@Bennx No, we shouldn't add that extension. This is already possible and would conflict with the Swift standard library.
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 93.63% 93.66% +0.03%
==========================================
Files 97 97
Lines 5544 5572 +28
==========================================
+ Hits 5191 5219 +28
Misses 353 353
Continue to review full report at Codecov.
|
|
@SD10 hope the format fits. |
|
@Bennx This would go under the |
|
@SD10 Got it. Cheers! |
Added a
isBetweenmethod to the date extension which can be used to determine if a date is between two given dates including or excluding the given dates itself. Default is to include the dates itself.Checklist