Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added decodePlist (decode file at url using PropertyListDecoder) #614

Open
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@AlexeiGitH
Copy link
Contributor

commented Dec 6, 2018

Decoder method to complete #603.

Checklist

  • I checked the Contributing Guidelines before creating this request.
  • New extensions are written in Swift 4.
  • New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
  • I have added tests for new extensions, and they passed.
  • All extensions have a clear comments explaining their functionality, all parameters and return type in English.
  • All extensions are declared as public.
  • I have added a changelog entry describing my changes.
Show resolved Hide resolved CHANGELOG.md Outdated
Show resolved Hide resolved Sources/Extensions/Foundation/FileManagerExtensions.swift Outdated
Show resolved Hide resolved Tests/FoundationTests/FileManagerExtensionsTests.swift Outdated
Show resolved Hide resolved Sources/Extensions/Foundation/FileManagerExtensions.swift Outdated
Show resolved Hide resolved Sources/Extensions/Foundation/FileManagerExtensions.swift Outdated
@LucianoPAlmeida

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Hey @AlexeiGitH Can you just resolve the conflicts with master? After that I think it will be good to go :)

@LucianoPAlmeida LucianoPAlmeida requested review from LucianoPAlmeida and removed request for LucianoPAlmeida Dec 24, 2018

@SwifterSwiftBot

This comment has been minimized.

Copy link

commented Jan 4, 2019

4 Messages
📖 Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.
📖 iOS: Executed 539 tests, with 0 failures (0 unexpected) in 16.196 (22.052) seconds
📖 tvOS: Executed 505 tests, with 0 failures (0 unexpected) in 7.498 (11.487) seconds
📖 macOS: Executed 369 tests, with 0 failures (0 unexpected) in 1.825 (2.185) seconds

SwiftLint found issues

Warnings

File Line Reason
FileManagerExtensionsTests.swift 92 Lines should not have trailing whitespace. (trailing_whitespace)
FileManagerExtensionsTests.swift 94 Lines should not have trailing whitespace. (trailing_whitespace)
FileManagerExtensionsTests.swift 97 Lines should not have trailing whitespace. (trailing_whitespace)
FileManagerExtensionsTests.swift 100 Lines should not have trailing whitespace. (trailing_whitespace)

Generated by 🚫 Danger

@codecov

This comment has been minimized.

Copy link

commented Jan 6, 2019

Codecov Report

Merging #614 into master will increase coverage by 9.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage    81.9%   91.32%   +9.42%     
==========================================
  Files          43       73      +30     
  Lines        1862     2837     +975     
==========================================
+ Hits         1525     2591    +1066     
+ Misses        337      246      -91
Flag Coverage Δ
#ios 93.47% <0%> (?)
#osx 81.76% <0%> (-0.14%) ⬇️
#tvos 91.87% <0%> (?)
Impacted Files Coverage Δ
.../Extensions/Foundation/FileManagerExtensions.swift 87.87% <0%> (-8.79%) ⬇️
Sources/Extensions/SwifterSwift.swift 17.27% <0%> (-40.31%) ⬇️
Sources/Extensions/Foundation/URLExtensions.swift 100% <0%> (ø) ⬆️
...xtensions/UIKit/UISegmentedControlExtensions.swift 100% <0%> (ø)
Sources/Extensions/UIKit/UIViewExtensions.swift 74.48% <0%> (ø)
...tensions/UIKit/UIGestureRecognizerExtensions.swift 100% <0%> (ø)
...urces/Extensions/UIKit/UITextFieldExtensions.swift 100% <0%> (ø)
...rces/Extensions/UIKit/UIEdgeInsetsExtensions.swift 100% <0%> (ø)
.../Extensions/UIKit/UIViewControllerExtensions.swift 97.95% <0%> (ø)
...Extensions/UIKit/UIAlertControllerExtensions.swift 79.31% <0%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c773f2b...0b4ab7a. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jan 6, 2019

Codecov Report

Merging #614 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   91.64%   91.67%   +0.03%     
==========================================
  Files          74       73       -1     
  Lines        2823     2822       -1     
==========================================
  Hits         2587     2587              
+ Misses        236      235       -1
Flag Coverage Δ
#ios 93.83% <100%> (+0.03%) ⬆️
#osx 84.26% <100%> (+0.03%) ⬆️
#tvos 94.49% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
.../Extensions/Foundation/FileManagerExtensions.swift 96.96% <100%> (+0.3%) ⬆️
Sources/Extensions/UIKit/UIImageExtensions.swift 100% <0%> (ø) ⬆️
...tStdlib/RangeReplaceableCollectionExtensions.swift 100% <0%> (ø) ⬆️
...urces/Extensions/SwiftStdlib/ArrayExtensions.swift 100% <0%> (ø) ⬆️
...ources/Extensions/MapKit/MKMapViewExtensions.swift

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e46620...c6f64d4. Read the comment docs.

guykogus added some commits Mar 9, 2019

@guykogus

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

@omaralbeik @LucianoPAlmeida can you please check?

@LucianoPAlmeida
Copy link
Member

left a comment

LGTM 👍
@omaralbeik Should we hold the merge to after swift-5 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.