Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): prevent --template-ref from being set without --template-source in renku init #2146

Merged
merged 5 commits into from Jun 21, 2021

Conversation

Panaetius
Copy link
Member

closes #2023

@Panaetius Panaetius requested a review from a team as a code owner June 9, 2021 09:20
@Panaetius Panaetius force-pushed the 2023-renku-init-ref-without-source branch from 231b034 to 55d6021 Compare June 9, 2021 09:28
@Panaetius Panaetius force-pushed the 2023-renku-init-ref-without-source branch 3 times, most recently from 49e7084 to 7fb5ab4 Compare June 9, 2021 11:23
Copy link
Contributor

@vigsterkr vigsterkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vigsterkr
vigsterkr previously approved these changes Jun 11, 2021
@Panaetius Panaetius enabled auto-merge (squash) June 14, 2021 09:32
@Panaetius Panaetius merged commit e687b08 into master Jun 21, 2021
@Panaetius Panaetius deleted the 2023-renku-init-ref-without-source branch June 21, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specifying -r without a source template should fail on init
2 participants