Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): set git credentials helper correctly on git clone #3348

Merged
merged 2 commits into from Mar 8, 2023
Merged

fix(cli): set git credentials helper correctly on git clone #3348

merged 2 commits into from Mar 8, 2023

Conversation

Panaetius
Copy link
Member

closes #3345

@Panaetius Panaetius requested a review from a team as a code owner March 6, 2023 09:57
@coveralls
Copy link
Collaborator

coveralls commented Mar 6, 2023 •
edited

Pull Request Test Coverage Report for Build 4354025272

  • 6 of 7 (85.71%) changed or added relevant lines in 3 files are covered.
  • 912 unchanged lines in 81 files lost coverage.
  • Overall coverage decreased (-2.8%) to 83.736%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/util/git.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
renku/command/clone.py 1 95.24%
renku/command/mergetool.py 1 84.85%
renku/core/dataset/providers/dataverse.py 1 88.85%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/domain_model/provenance/agent.py 1 81.72%
renku/domain_model/workflow/composite_plan.py 1 81.55%
renku/infrastructure/immutable.py 1 92.42%
renku/ui/cli/clone.py 1 92.31%
renku/ui/service/controllers/templates_create_project.py 1 94.87%
renku/ui/service/controllers/utils/remote_project.py 1 89.19%
Totals Coverage Status
Change from base Build 4352635705: -2.8%
Covered Lines: 24533
Relevant Lines: 29298
💛 - Coveralls

mana-alisafaee
mana-alisafaee approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@mana-alisafaee mana-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Panaetius Panaetius merged commit ac21c32 into develop Mar 8, 2023
29 of 30 checks passed
@Panaetius Panaetius deleted the bugfix/3345-fix-credentials-helper branch March 8, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mana-alisafaee mana-alisafaee mana-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect hostname for credentials helper
3 participants
@Panaetius @coveralls @mana-alisafaee