New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing config for Linux-environments #17

Merged
merged 2 commits into from Oct 18, 2018

Conversation

Projects
None yet
2 participants
@4ch1m
Contributor

4ch1m commented Oct 12, 2018

This is a bug for Linux-systems, which will crash the script when a pre-/post-build script is being used.

The (dictionary-)entries env and path never get set/initialized in KickAssembler(C64).sublime-build when running on a Linux-environment.
And then the script crashes when it tries to access env.update().

    def addPrePostVarsToDict(self, sourceDict, buildMode):
        prePostEnvVars = {
            "kickass_buildmode": buildMode,
...
            }
        sourceDict.get('env').update(prePostEnvVars)
        return sourceDict

This PR will fix this by simpy initializing these dict-entries with empty values.

"linux":
{
"env" : {},
"path": ""

This comment has been minimized.

@Swoffa

Swoffa Oct 18, 2018

Owner
Suggested change Beta
"path": ""
"path": "$PATH"

For safety, if PATH would be initialized.

@Swoffa

This comment has been minimized.

Owner

Swoffa commented Oct 18, 2018

Thanks!
See comment, then we can merge. :)

@4ch1m

This comment has been minimized.

Contributor

4ch1m commented Oct 18, 2018

Yep, that's definitely better. 😃
Fixed.
Thanks, Swoffa.

@Swoffa Swoffa merged commit b1ea173 into Swoffa:master Oct 18, 2018

@4ch1m 4ch1m deleted the 4ch1m:fix_config_for_linux branch Oct 22, 2018

BroneCk pushed a commit to BroneCk/SublimeKickAssemblerC64 that referenced this pull request Nov 18, 2018

add missing config for Linux-environments (Swoffa#17)
* add missing config for Linux-environments

* initialize/set default '$PATH'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment