Skip to content

/ SublimeKickAssemblerC64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Feature: Setting for default prebuild-/postbuild-path #25

Merged
merged 5 commits into from Oct 24, 2018
Merged

New Feature: Setting for default prebuild-/postbuild-path #25

merged 5 commits into from Oct 24, 2018

Conversation

@4ch1m
Copy link
Contributor

@4ch1m 4ch1m commented Oct 22, 2018

Another small feature/improvement. ;-)

I pretty much always want to run the same "prebuild.sh" before building/running any ASM-file (simply to execute 'killall x64', etc.).
ATM I have to place a copy of my "prebuild.sh"-file into the folder where the ASM-file resides.
And if I ever change/update my "prebuild.sh"-file I will have to change/udpate all existing copies of it. :(
(I know that I could use symlinks... but the symlinks also will have to be created manually every time; for every directory I intend to build/run a ASM-file. And Windows-users also might not have the possibility of using symlinks.)

With this PR you can define a default-path where the "prebuild.sh"-file is located via a simple settings-entry.
Any "prebuild.sh" located in the ASM-file-directory will still take precedence; but if none is present we also check the default path.

Oh... and all of this also applies for the "postbuild.sh". :)
4ch1m added 2 commits Oct 22, 2018
@4ch1m
Merge pull request #1 from Swoffa/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7bff9d5 
sync master
@4ch1m
new feature: default pre-/post-build-path via settings
c8fbc57
@Swoffa
Copy link
Owner

@Swoffa Swoffa commented Oct 23, 2018 •
edited

@4ch1m
Recently i moved all settings to file KickAssembler (C64).sublime-settings, but i found out it was not a good idea, so i moved them back to Preferences.sublime-settings. This makes merge problems for this PR, sorry. Can you fix the conflict by moving your settings to Preferences.sublime-settings?
@og2t
Copy link
Contributor

@og2t og2t commented Oct 23, 2018

This will be fantastic to merge. I am using a similar setup where I have .sh script files to build, kill x64 and run the code. I was actually hacking SublimeKickAssemblerC64 build process to trigger my scripts instead altogether until now ;-)
4ch1m added 3 commits Oct 23, 2018
@4ch1m
Merge pull request #2 from Swoffa/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a3cccbc 
sync master
@4ch1m
Merge branch 'master' into feature/settings_for_default_prebuild_post…
9412dbe 
…build

# Conflicts:
#	KickAssembler (C64).sublime-settings
#	kickass_build.py
@4ch1m
new feature: default pre-/post-build-path via settings
56ca434
@4ch1m
Copy link
Contributor Author

@4ch1m 4ch1m commented Oct 23, 2018

@Swoffa: OK.
I just synced with master and adjusted everything accordingly.
@Swoffa
Copy link
Owner

@Swoffa Swoffa commented Oct 24, 2018

@4ch1m
Great feature, thanks!
@Swoffa Swoffa merged commit 177db39 into Swoffa:master Oct 24, 2018
@Swoffa
Copy link
Owner

@Swoffa Swoffa commented Oct 24, 2018

@4ch1m
I fixed an issue that environment variables were not added for global pre/post scripts. In master.
@4ch1m 4ch1m deleted the 4ch1m:feature/settings_for_default_prebuild_postbuild branch Oct 24, 2018
BroneCk pushed a commit to BroneCk/SublimeKickAssemblerC64 that referenced this pull request Nov 18, 2018
@4ch1m @Swoffa
New Feature: Setting for default prebuild-/postbuild-path (Swoffa#25)
f640c0f 
* new feature: default pre-/post-build-path via settings

* new feature: default pre-/post-build-path via settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@4ch1m @Swoffa @og2t