Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added border radius to search bar #1904

Merged
merged 4 commits into from Oct 8, 2022

Conversation

JayrajSingh65
Copy link
Contributor

  • hey its looking good right now

@CandidDeer
Copy link
Collaborator

@Syknapse Please review these general changes.

Copy link
Owner

@Syknapse Syknapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thank you. We will merge it now.

For your future reference, when changes have been requested on a pull request you can make the changes locally on your machine, and as soon as you push your changes the pull request will update automatically with the new changes. You shouldn't open a new PR for changes.

In this case it's ok, i will merge this PR and you will have to close the other PR.

@JayrajSingh65
Copy link
Contributor Author

This is great thank you. We will merge it now.

For your future reference, when changes have been requested on a pull request you can make the changes locally on your machine, and as soon as you push your changes the pull request will update automatically with the new changes. You shouldn't open a new PR for changes.

In this case it's ok, i will merge this PR and you will have to close the other PR.

-Thanks I got it

@Syknapse Syknapse merged commit 3c96800 into Syknapse:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants