New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shop api /verify-account route #386

Merged
merged 3 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@nevoeiro
Copy link

nevoeiro commented Jan 31, 2019

In order to complete the activation of new registered users I propose to change the method of sylius_shop_api_user_verification route to [GET] so we are able to access the activation url sent in ShopApiPlugin:Email:verification.html.twig template, when a user registers through shop api.

carlos.boita
Fixed shop api /verify-account route
* Changed sylius_shop_api_user_verification route method to GET
* Fixed get request parameter `token` to support both request and query parameters

@nevoeiro nevoeiro requested a review from Sylius/core-team as a code owner Jan 31, 2019

@nevoeiro nevoeiro force-pushed the turbine-kreuzberg:fix_api_verify_account_route branch from a0298e5 to d41eddb Feb 1, 2019

@lchrusciel lchrusciel added the Bug label Feb 8, 2019

@lchrusciel lchrusciel merged commit bc9f836 into Sylius:master Feb 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lchrusciel

This comment has been minimized.

Copy link
Member

lchrusciel commented Feb 8, 2019

Thanks, @nevoeiro! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment