From 5bc148c02feef799497d5251f84499c87ac88bbf Mon Sep 17 00:00:00 2001
From: arti0090 <arti0090@gmail.com>
Date: Fri, 19 Feb 2021 09:24:31 +0100
Subject: [PATCH] add copyright blocks, add phpspec for handler, fix issues

---
 src/Sylius/Behat/Context/Api/EmailContext.php |  9 +++
 .../Behat/Context/Api/Shop/LoginContext.php   |  2 +-
 .../config/services/contexts/api.xml          |  4 +-
 ...word.php => RequestResetPasswordToken.php} | 11 ++-
 .../Command/SendResetPasswordEmail.php        |  9 +++
 ...p => RequestResetPasswordTokenHandler.php} | 19 +++--
 .../SendResetPasswordEmailHandler.php         | 14 +++-
 .../Event/ResetPasswordRequested.php          |  9 +++
 .../ResetPasswordRequestedHandler.php         | 12 +++-
 .../config/api_resources/Customer.xml         |  6 +-
 .../Commands/Account/ResetPassword.xml        |  4 +-
 .../config/services/command_handlers.xml      |  2 +-
 .../config/validation/ResetPassword.xml       |  2 +-
 .../SendResetPasswordEmailHandlerSpec.php     | 71 +++++++++++++++++++
 14 files changed, 154 insertions(+), 20 deletions(-)
 rename src/Sylius/Bundle/ApiBundle/Command/{ResetPassword.php => RequestResetPasswordToken.php} (72%)
 rename src/Sylius/Bundle/ApiBundle/CommandHandler/{ResetPasswordHandler.php => RequestResetPasswordTokenHandler.php} (74%)
 create mode 100644 src/Sylius/Bundle/ApiBundle/spec/CommandHandler/SendResetPasswordEmailHandlerSpec.php

diff --git a/src/Sylius/Behat/Context/Api/EmailContext.php b/src/Sylius/Behat/Context/Api/EmailContext.php
index 2922ac8342f..4c68f30034a 100644
--- a/src/Sylius/Behat/Context/Api/EmailContext.php
+++ b/src/Sylius/Behat/Context/Api/EmailContext.php
@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Paweł Jędrzejewski
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Sylius\Behat\Context\Api;
diff --git a/src/Sylius/Behat/Context/Api/Shop/LoginContext.php b/src/Sylius/Behat/Context/Api/Shop/LoginContext.php
index cd2a59fab53..7441d1ba3f9 100644
--- a/src/Sylius/Behat/Context/Api/Shop/LoginContext.php
+++ b/src/Sylius/Behat/Context/Api/Shop/LoginContext.php
@@ -65,7 +65,7 @@ public function iWantToLogIn(): void
      */
     public function iWantToResetPassword(): void
     {
-        $this->request = Request::create('shop', 'password-reset-request', 'Bearer');
+        $this->request = Request::create('shop', 'request-reset-password', 'Bearer');
     }
 
     /**
diff --git a/src/Sylius/Behat/Resources/config/services/contexts/api.xml b/src/Sylius/Behat/Resources/config/services/contexts/api.xml
index 8c4266275f9..22594485204 100644
--- a/src/Sylius/Behat/Resources/config/services/contexts/api.xml
+++ b/src/Sylius/Behat/Resources/config/services/contexts/api.xml
@@ -16,8 +16,6 @@
            xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"
 >
     <imports>
-        <import resource="api/admin.xml" />
-        <import resource="api/shop.xml" />
-        <import resource="api/email.xml" />
+        <import resource="api/**/*.xml" />
     </imports>
 </container>
diff --git a/src/Sylius/Bundle/ApiBundle/Command/ResetPassword.php b/src/Sylius/Bundle/ApiBundle/Command/RequestResetPasswordToken.php
similarity index 72%
rename from src/Sylius/Bundle/ApiBundle/Command/ResetPassword.php
rename to src/Sylius/Bundle/ApiBundle/Command/RequestResetPasswordToken.php
index 3b2fd696673..9437cb6f8ae 100644
--- a/src/Sylius/Bundle/ApiBundle/Command/ResetPassword.php
+++ b/src/Sylius/Bundle/ApiBundle/Command/RequestResetPasswordToken.php
@@ -1,10 +1,19 @@
 <?php
 
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Paweł Jędrzejewski
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Sylius\Bundle\ApiBundle\Command;
 
-class ResetPassword implements ChannelCodeAwareInterface, LocaleCodeAwareInterface
+class RequestResetPasswordToken implements ChannelCodeAwareInterface, LocaleCodeAwareInterface
 {
     /** @var string */
     public $email;
diff --git a/src/Sylius/Bundle/ApiBundle/Command/SendResetPasswordEmail.php b/src/Sylius/Bundle/ApiBundle/Command/SendResetPasswordEmail.php
index 1c0501b1168..4a6ee777204 100644
--- a/src/Sylius/Bundle/ApiBundle/Command/SendResetPasswordEmail.php
+++ b/src/Sylius/Bundle/ApiBundle/Command/SendResetPasswordEmail.php
@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Paweł Jędrzejewski
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Sylius\Bundle\ApiBundle\Command;
diff --git a/src/Sylius/Bundle/ApiBundle/CommandHandler/ResetPasswordHandler.php b/src/Sylius/Bundle/ApiBundle/CommandHandler/RequestResetPasswordTokenHandler.php
similarity index 74%
rename from src/Sylius/Bundle/ApiBundle/CommandHandler/ResetPasswordHandler.php
rename to src/Sylius/Bundle/ApiBundle/CommandHandler/RequestResetPasswordTokenHandler.php
index d241786b672..76a207ffbf9 100644
--- a/src/Sylius/Bundle/ApiBundle/CommandHandler/ResetPasswordHandler.php
+++ b/src/Sylius/Bundle/ApiBundle/CommandHandler/RequestResetPasswordTokenHandler.php
@@ -1,10 +1,19 @@
 <?php
 
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Paweł Jędrzejewski
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Sylius\Bundle\ApiBundle\CommandHandler;
 
-use Sylius\Bundle\ApiBundle\Command\ResetPassword;
+use Sylius\Bundle\ApiBundle\Command\RequestResetPasswordToken;
 use Sylius\Bundle\ApiBundle\Event\ResetPasswordRequested;
 use Sylius\Component\User\Repository\UserRepositoryInterface;
 use Sylius\Component\User\Security\Generator\GeneratorInterface;
@@ -12,7 +21,7 @@
 use Symfony\Component\Messenger\Stamp\DispatchAfterCurrentBusStamp;
 use Webmozart\Assert\Assert;
 
-class ResetPasswordHandler
+final class RequestResetPasswordTokenHandler
 {
     /** @var UserRepositoryInterface */
     private $userRepository;
@@ -33,7 +42,7 @@ public function __construct(
         $this->generator = $generator;
     }
 
-    public function __invoke(ResetPassword $command): void
+    public function __invoke(RequestResetPasswordToken $command): void
     {
         $user = $this->userRepository->findOneByEmail($command->getEmail());
         Assert::notNull($user);
@@ -43,7 +52,7 @@ public function __invoke(ResetPassword $command): void
 
         $this->eventBus->dispatch(
             new ResetPasswordRequested($command->getEmail(), $command->getChannelCode(), $command->getLocaleCode()),
-            [new DispatchAfterCurrentBusStamp()
-        ]);
+            [new DispatchAfterCurrentBusStamp()]
+        );
     }
 }
diff --git a/src/Sylius/Bundle/ApiBundle/CommandHandler/SendResetPasswordEmailHandler.php b/src/Sylius/Bundle/ApiBundle/CommandHandler/SendResetPasswordEmailHandler.php
index 7457d4a1a5e..279ceaf480f 100644
--- a/src/Sylius/Bundle/ApiBundle/CommandHandler/SendResetPasswordEmailHandler.php
+++ b/src/Sylius/Bundle/ApiBundle/CommandHandler/SendResetPasswordEmailHandler.php
@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Paweł Jędrzejewski
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Sylius\Bundle\ApiBundle\CommandHandler;
@@ -9,8 +18,9 @@
 use Sylius\Component\Channel\Repository\ChannelRepositoryInterface;
 use Sylius\Component\Mailer\Sender\SenderInterface;
 use Sylius\Component\User\Repository\UserRepositoryInterface;
+use Symfony\Component\Messenger\Handler\MessageHandlerInterface;
 
-class SendResetPasswordEmailHandler
+final class SendResetPasswordEmailHandler implements MessageHandlerInterface
 {
     /** @var SenderInterface */
     private $emailSender;
@@ -42,7 +52,7 @@ public function __invoke(SendResetPasswordEmail $command)
             [
                 'user' => $user,
                 'localeCode' => $command->localeCode(),
-                'channel' => $channel
+                'channel' => $channel,
             ]
         );
     }
diff --git a/src/Sylius/Bundle/ApiBundle/Event/ResetPasswordRequested.php b/src/Sylius/Bundle/ApiBundle/Event/ResetPasswordRequested.php
index dabb8814bef..bb55a654901 100644
--- a/src/Sylius/Bundle/ApiBundle/Event/ResetPasswordRequested.php
+++ b/src/Sylius/Bundle/ApiBundle/Event/ResetPasswordRequested.php
@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Paweł Jędrzejewski
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Sylius\Bundle\ApiBundle\Event;
diff --git a/src/Sylius/Bundle/ApiBundle/EventHandler/ResetPasswordRequestedHandler.php b/src/Sylius/Bundle/ApiBundle/EventHandler/ResetPasswordRequestedHandler.php
index c2cc5171a95..80fa3a23980 100644
--- a/src/Sylius/Bundle/ApiBundle/EventHandler/ResetPasswordRequestedHandler.php
+++ b/src/Sylius/Bundle/ApiBundle/EventHandler/ResetPasswordRequestedHandler.php
@@ -1,5 +1,14 @@
 <?php
 
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Paweł Jędrzejewski
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 declare(strict_types=1);
 
 namespace Sylius\Bundle\ApiBundle\EventHandler;
@@ -8,7 +17,8 @@
 use Sylius\Bundle\ApiBundle\Event\ResetPasswordRequested;
 use Symfony\Component\Messenger\MessageBusInterface;
 
-class ResetPasswordRequestedHandler
+/** @experimental */
+final class ResetPasswordRequestedHandler
 {
     /** @var MessageBusInterface */
     private $commandBus;
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Customer.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Customer.xml
index ff8586dc25a..cd456bc5dc9 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Customer.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Customer.xml
@@ -36,9 +36,9 @@
 
             <collectionOperation name="shop_password_reset_request">
                 <attribute name="method">POST</attribute>
-                <attribute name="path">shop/password-reset-request</attribute>
+                <attribute name="path">shop/request-reset-password</attribute>
                 <attribute name="messenger">input</attribute>
-                <attribute name="input">Sylius\Bundle\ApiBundle\Command\ResetPassword</attribute>
+                <attribute name="input">Sylius\Bundle\ApiBundle\Command\RequestResetPasswordToken</attribute>
                 <attribute name="output">false</attribute>
                 <attribute name="status">202</attribute>
                 <attribute name="validation_groups">
@@ -46,7 +46,7 @@
                     <attribute>sylius_shop_password_reset</attribute>
                 </attribute>
                 <attribute name="normalization_context">
-                    <attribute name="groups">shop:customer:password_reset</attribute>
+                    <attribute name="groups">shop:password_reset:create</attribute>
                 </attribute>
                 <attribute name="openapi_context">
                     <attribute name="summary">Request password reset</attribute>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Commands/Account/ResetPassword.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Commands/Account/ResetPassword.xml
index a8f7f064269..194ac5cd5b9 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Commands/Account/ResetPassword.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Commands/Account/ResetPassword.xml
@@ -17,10 +17,10 @@
 >
     <class name="Sylius\Bundle\ApiBundle\Command\ResetPassword">
         <attribute name="email">
-            <group>shop:customer:password_reset</group>
+            <group>shop:password_reset:create</group>
         </attribute>
         <attribute name="localeCode">
-            <group>shop:customer:password_reset</group>
+            <group>shop:password_reset:create</group>
         </attribute>
     </class>
 </serializer>
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/services/command_handlers.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/services/command_handlers.xml
index ac6bebaec18..531d285161e 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/services/command_handlers.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/services/command_handlers.xml
@@ -102,7 +102,7 @@
             <tag name="messenger.message_handler" bus="sylius_default.bus"/>
         </service>
 
-        <service id="Sylius\Bundle\ApiBundle\CommandHandler\ResetPasswordHandler">
+        <service id="Sylius\Bundle\ApiBundle\CommandHandler\RequestResetPasswordTokenHandler">
             <argument type="service" id="sylius.repository.shop_user" />
             <argument type="service" id="sylius_event.bus" />
             <argument type="service" id="sylius.shop_user.token_generator.password_reset" />
diff --git a/src/Sylius/Bundle/ApiBundle/Resources/config/validation/ResetPassword.xml b/src/Sylius/Bundle/ApiBundle/Resources/config/validation/ResetPassword.xml
index 23ab56caa00..e22a04d6c04 100644
--- a/src/Sylius/Bundle/ApiBundle/Resources/config/validation/ResetPassword.xml
+++ b/src/Sylius/Bundle/ApiBundle/Resources/config/validation/ResetPassword.xml
@@ -15,7 +15,7 @@
                     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                     xsi:schemaLocation="http://symfony.com/schema/dic/constraint-mapping http://symfony.com/schema/dic/services/constraint-mapping-1.0.xsd">
 
-    <class name="Sylius\Bundle\ApiBundle\Command\ResetPassword">
+    <class name="Sylius\Bundle\ApiBundle\Command\RequestResetPasswordToken">
         <property name="email">
             <constraint name="NotBlank">
                 <option name="message">sylius.customer.email.not_blank</option>
diff --git a/src/Sylius/Bundle/ApiBundle/spec/CommandHandler/SendResetPasswordEmailHandlerSpec.php b/src/Sylius/Bundle/ApiBundle/spec/CommandHandler/SendResetPasswordEmailHandlerSpec.php
new file mode 100644
index 00000000000..10ff2de8882
--- /dev/null
+++ b/src/Sylius/Bundle/ApiBundle/spec/CommandHandler/SendResetPasswordEmailHandlerSpec.php
@@ -0,0 +1,71 @@
+<?php
+
+/*
+ * This file is part of the Sylius package.
+ *
+ * (c) Paweł Jędrzejewski
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace spec\Sylius\Bundle\ApiBundle\CommandHandler;
+
+use PhpSpec\ObjectBehavior;
+use Sylius\Bundle\ApiBundle\Command\SendResetPasswordEmail;
+use Sylius\Bundle\CoreBundle\Mailer\Emails;
+use Sylius\Component\Channel\Repository\ChannelRepositoryInterface;
+use Sylius\Component\Core\Model\ChannelInterface;
+use Sylius\Component\Mailer\Sender\SenderInterface;
+use Sylius\Component\User\Model\UserInterface;
+use Sylius\Component\User\Repository\UserRepositoryInterface;
+use Symfony\Component\Messenger\Handler\MessageHandlerInterface;
+
+final class SendResetPasswordEmailHandlerSpec extends ObjectBehavior
+{
+    function let(
+        SenderInterface $emailSender,
+        ChannelRepositoryInterface $channelRepository,
+        UserRepositoryInterface $userRepository
+    ): void {
+        $this->beConstructedWith($emailSender, $channelRepository, $userRepository);
+    }
+
+    function it_is_a_message_handler(): void
+    {
+        $this->shouldImplement(MessageHandlerInterface::class);
+    }
+
+    function it_sends_message_with_reset_password_token(
+        SenderInterface $sender,
+        UserRepositoryInterface $userRepository,
+        SendResetPasswordEmail $sendResetPasswordEmail,
+        UserInterface $user,
+        ChannelRepositoryInterface $channelRepository,
+        ChannelInterface $channel
+    ): void {
+        $sendResetPasswordEmail->email()->willReturn('iAmAnEmail@spaghettiCode.php');
+
+        $userRepository->findOneByEmail('iAmAnEmail@spaghettiCode.php')->willReturn($user);
+
+        $sendResetPasswordEmail->channelCode()->willReturn('WEB');
+
+        $channelRepository->findOneByCode('WEB')->willReturn($channel);
+
+        $sendResetPasswordEmail->localeCode()->willReturn('en_US');
+
+        $sender->send(
+            Emails::PASSWORD_RESET,
+            ['iAmAnEmail@spaghettiCode.php'],
+            [
+                'user' => $user->getWrappedObject(),
+                'localeCode' => 'en_US',
+                'channel' => $channel->getWrappedObject(),
+            ]
+        );
+
+        $this(new SendResetPasswordEmail('iAmAnEmail@spaghettiCode.php', 'WEB', 'en_US'));
+    }
+}