From 72236ab70c50786b7664ba351d6aa18f60c64e95 Mon Sep 17 00:00:00 2001
From: Jacob Tobiasz <jakub.tobiasz@icloud.com>
Date: Tue, 12 Dec 2023 19:01:50 +0100
Subject: [PATCH] Remove duplicated step

---
 .../Admin/BrowsingProductVariantsContext.php    | 17 -----------------
 .../Admin/ManagingProductVariantsContext.php    |  1 +
 .../config/services/contexts/api/admin.xml      |  1 -
 3 files changed, 1 insertion(+), 18 deletions(-)

diff --git a/src/Sylius/Behat/Context/Api/Admin/BrowsingProductVariantsContext.php b/src/Sylius/Behat/Context/Api/Admin/BrowsingProductVariantsContext.php
index 3cca2d1674aa..6c09f1aa1cb8 100644
--- a/src/Sylius/Behat/Context/Api/Admin/BrowsingProductVariantsContext.php
+++ b/src/Sylius/Behat/Context/Api/Admin/BrowsingProductVariantsContext.php
@@ -13,12 +13,10 @@
 
 namespace Sylius\Behat\Context\Api\Admin;
 
-use ApiPlatform\Api\IriConverterInterface;
 use Behat\Behat\Context\Context;
 use Sylius\Behat\Client\ApiClientInterface;
 use Sylius\Behat\Client\ResponseCheckerInterface;
 use Sylius\Behat\Context\Api\Resources;
-use Sylius\Component\Core\Model\ProductInterface;
 use Sylius\Component\Core\Model\ProductVariantInterface;
 use Webmozart\Assert\Assert;
 
@@ -27,24 +25,9 @@ final class BrowsingProductVariantsContext implements Context
     public function __construct (
         private ApiClientInterface $client,
         private ResponseCheckerInterface $responseChecker,
-        private IriConverterInterface $iriConverter,
     ) {
     }
 
-    /**
-     * @When I view all variants of the product :product
-     */
-    public function iViewAllVariantsOfTheProduct(ProductInterface $product): void
-    {
-        $this->client->index(
-            Resources::PRODUCT_VARIANTS,
-            [
-                'product' => $this->iriConverter->getIriFromResource($product),
-                'order[position]' => 'asc',
-            ],
-        );
-    }
-
     /**
      * @When I start sorting variants by position
      */
diff --git a/src/Sylius/Behat/Context/Api/Admin/ManagingProductVariantsContext.php b/src/Sylius/Behat/Context/Api/Admin/ManagingProductVariantsContext.php
index 44f5a6f206f0..758f0e5cf608 100644
--- a/src/Sylius/Behat/Context/Api/Admin/ManagingProductVariantsContext.php
+++ b/src/Sylius/Behat/Context/Api/Admin/ManagingProductVariantsContext.php
@@ -234,6 +234,7 @@ public function iWantToViewAllVariantsOfThisProduct(ProductInterface $product):
     {
         $this->client->index(Resources::PRODUCT_VARIANTS);
         $this->client->addFilter('product', $this->iriConverter->getIriFromResource($product));
+        $this->client->addFilter('order[position]', 'asc');
         $this->client->filter();
     }
 
diff --git a/src/Sylius/Behat/Resources/config/services/contexts/api/admin.xml b/src/Sylius/Behat/Resources/config/services/contexts/api/admin.xml
index 3a0f3e78fbe6..6ef0d9482b47 100644
--- a/src/Sylius/Behat/Resources/config/services/contexts/api/admin.xml
+++ b/src/Sylius/Behat/Resources/config/services/contexts/api/admin.xml
@@ -43,7 +43,6 @@
         <service id="Sylius\Behat\Context\Api\Admin\BrowsingProductVariantsContext">
             <argument type="service" id="sylius.behat.api_platform_client.admin" />
             <argument type="service" id="Sylius\Behat\Client\ResponseCheckerInterface" />
-            <argument type="service" id="api_platform.iri_converter" />
         </service>
 
         <service id="Sylius\Behat\Context\Api\Admin\CreatingProductVariantContext">