Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixture] Togglable default locale loading #10342

Merged
merged 1 commit into from May 20, 2019

Conversation

lchrusciel
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #10307
License MIT

Opened to master as it is a new feature at the end.

@lchrusciel lchrusciel requested a review from a team as a code owner April 29, 2019 13:13
@lchrusciel lchrusciel mentioned this pull request Apr 29, 2019
1 task
@lchrusciel lchrusciel force-pushed the locales-fix branch 2 times, most recently from 33ebb7b to a9a82f6 Compare April 29, 2019 13:18
@CoderMaggie CoderMaggie added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label May 9, 2019
@igormukhingmailcom
Copy link
Contributor

Hi, guys.
Any chance this PR will be merged?

@lchrusciel
Copy link
Member Author

Hello Igor,

this PR was red due to the problem with the side library. I have restarted a build.

@lchrusciel lchrusciel force-pushed the locales-fix branch 2 times, most recently from 881a091 to f8f7be5 Compare May 13, 2019 11:53
@bartoszpietrzak1994
Copy link
Contributor

Could you document the behavior that you want to add in this PR? It would be great if our docs informed the users about the load_default_locale flag.

@lchrusciel
Copy link
Member Author

Good idea, but I don't know where should it be placed. We don't have any option documented around fixtures configuration.

Thus, we can open an issue about missing documentation after merging this PR

@Zales0123
Copy link
Member

I'm a little bit afraid it can be written and forgotten :( Maybe we can add a quick note in this chapter of documentation? Just to not forget it and then open an issue about missing documentation 😄

@lchrusciel
Copy link
Member Author

I'm voting for merging this feature and let's focus on documentation form in separate PR (#10393)

@Zales0123 Zales0123 merged commit deb0db3 into Sylius:master May 20, 2019
@Zales0123
Copy link
Member

Thank you, Łukasz! 🥇

@lchrusciel lchrusciel deleted the locales-fix branch May 20, 2019 07:41
@igormukhingmailcom
Copy link
Contributor

Thank you guys :)

pamil added a commit that referenced this pull request Jun 13, 2019
…le fixture (lchrusciel)

This PR was merged into the 1.6-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | documentation for #10342 
| License         | MIT


Commits
-------

d29a075 [Docs] Describe available configuration options for locale fixture
pamil added a commit that referenced this pull request Jun 24, 2019
…ture (pamil)

This PR was merged into the 1.4 branch.

Discussion
----------

Related to #10342.

Commits
-------

ffa464e Provide failing test scenario for duplicated locales
2562553 Deduplicate created locales in the fixtures
8699319 Refactor locale fixture spec to use mocks
c94006a Apply coding standards fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixtures: Avoid using $baseLocale at LocaleFixture
6 participants