New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixture] Togglable default locale loading #10342
Conversation
33ebb7b
to
a9a82f6
Compare
Hi, guys. |
Hello Igor, this PR was red due to the problem with the side library. I have restarted a build. |
881a091
to
f8f7be5
Compare
Could you document the behavior that you want to add in this PR? It would be great if our docs informed the users about the |
Good idea, but I don't know where should it be placed. We don't have any option documented around fixtures configuration. Thus, we can open an issue about missing documentation after merging this PR |
I'm a little bit afraid it can be written and forgotten :( Maybe we can add a quick note in this chapter of documentation? Just to not forget it and then open an issue about missing documentation 😄 |
I'm voting for merging this feature and let's focus on documentation form in separate PR (#10393) |
Thank you, Łukasz! 🥇 |
Thank you guys :) |
…le fixture (lchrusciel) This PR was merged into the 1.6-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | documentation for #10342 | License | MIT Commits ------- d29a075 [Docs] Describe available configuration options for locale fixture
…ture (pamil) This PR was merged into the 1.4 branch. Discussion ---------- Related to #10342. Commits ------- ffa464e Provide failing test scenario for duplicated locales 2562553 Deduplicate created locales in the fixtures 8699319 Refactor locale fixture spec to use mocks c94006a Apply coding standards fixes
Opened to master as it is a new feature at the end.