Adding a coupon generator command

[mamazu]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	none
License	MIT

For people who like to generate coupon codes with the command line I have written a command to do so.

[mamazu]

I am trying to write a behat test but I am not sure how to mock the dependencies properly. The other commands use the container aware command as their base class which is deprecated. Should the GenerateCouponCommand also use this and if not how do I instantiate it.

[lchrusciel]

What about some functional test with PHPunit, where we will generate some commands and assert if they are available in the database?

[mamazu]

I will try to get to it this evening.

[mamazu]

Is there any kind of reference for a command that is tested with phpunit?

[Zales0123]

https://symfony.com/doc/current/console.html#testing-commands this can be useful, for the start

[mamazu]

Done. :D

[lchrusciel]

Minor cs problems, vendor/bin/ecs check --ansi --no-progress-bar path-toyour-classes --fix should fix it. Other than that, good to go.

[mamazu]

Yeah, right forgot that. 👍

[mamazu]

@Zales0123 What do you think?

[lchrusciel]

Could be finalized

[lchrusciel]

Thanks, @mamazu! 🥇

[ggabrovski]

You have related the command to the core component and this will make problem if the PromotionBundle is integrated into Symfony app, without the Sylius core component.

I suggest to change this:
use Sylius\Component\Core\Model\PromotionInterface;
use Sylius\Component\Core\Repository\PromotionRepositoryInterface;

to:
use Sylius\Component\Promotion\Model\PromotionInterface;
use Sylius\Component\Promotion\Repository\PromotionRepositoryInterface;

[alexsegura]

Yes, there is a problem, see #10692

[mamazu]

True I didn't thought of that and this should be fixed.