[Api][Administrator] refactor endpoints for admin and admin avatar #11776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Aug 31, 2020
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | 1.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | #11250 |
| License | MIT |
AdamKasp
commented
Aug 31, 2020
| @@ -211,4 +211,13 @@ private function mergeArraysUniquely(array $firstArray, array $secondArray): arr | |||
|
|
|||
| return $firstArray; | |||
| } | |||
|
|
|||
| private static function prepareSection(?string $section): string | |||
There was a problem hiding this comment.
this function should be deleted after refactor all new API endpoints, for now only refactored endpoint have section prefix, without this logic a have problems with pathnames while testing.
There was a problem hiding this comment.
IMHO, we can leave it for the future, to give possibility of using this class without any section
lchrusciel
approved these changes
Aug 31, 2020
| AbstractBrowser $client, | ||
| SharedStorageInterface $sharedStorage, | ||
| string $resource, | ||
| string $section = null |
There was a problem hiding this comment.
Suggested change
| string $section = null | |
| ?string $section = null |
There was a problem hiding this comment.
I will fix it in the next PR.
AdamKasp
force-pushed
the
api-refactor-admin-and-avatar-endpoints
branch
from
38668a3
to
81bebec
Compare
lchrusciel
approved these changes
Sep 1, 2020
|
Thank you, Adam! 🥇 |
Tomanhez
approved these changes
Sep 1, 2020
lchrusciel
added a commit
that referenced
this pull request
Sep 1, 2020
This PR was merged into the 1.8 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Related tickets | part of #11250, based on #11776 | License | MIT <!-- - Bug fixes must be submitted against the 1.7 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- dc45032 [API] refactor endpoint for api resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.