Refreshed shop theme #13806
Merged
Refreshed shop theme #13806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulczy
added
UX
vvasiloi
approved these changes
Mar 29, 2022
|
@kulczy Awesome, looks great to me! As great as it can be with Semantic UI. :D |
Roshyo
approved these changes
Mar 30, 2022
GSadee
approved these changes
Mar 30, 2022
| @@ -1,4 +1,5 @@ | |||
| <footer id="footer" class="ui inverted vertical footer segment"> | |||
| {% include "@SyliusShop/Layout/Footer/Grid/_pre_footer.html.twig" %} | |||
There was a problem hiding this comment.
I know that the Symfony recommendation is to use snake_case for Twig templates, but in Sylius we have been using camelCase for ages:
Suggested change
| {% include "@SyliusShop/Layout/Footer/Grid/_pre_footer.html.twig" %} | |
| {% include "@SyliusShop/Layout/Footer/Grid/_preFooter.html.twig" %} |
There was a problem hiding this comment.
yeah You're right, but in this particular folder, all files (don't know why) are named that way, so I didn't want to break the convention
|
Thank you, Szymon! 🥇 |
GSadee
added a commit
that referenced
this pull request
Sep 21, 2022
…ooo) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 <!-- see the comment below --> | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | #13806 | License | MIT | This PR fixes a bug on the offer view The previous Sylius layout: <img width="1381" alt="image" src="https://user-images.githubusercontent.com/40125720/191003290-00b9d11c-5730-40ae-a0dc-ae7c11adf335.png"> Fixes: <img width="1077" alt="image" src="https://user-images.githubusercontent.com/40125720/191003706-335a3f6a-05b3-4474-8ced-3098f919259b.png"> Commits ------- 435fb07 [UI] removed important flag from the button class
GSadee
added a commit
to Sylius/SyliusShopBundle
that referenced
this pull request
Sep 21, 2022
…ooo) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 <!-- see the comment below --> | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | Sylius/Sylius#13806 | License | MIT | This PR fixes a bug on the offer view The previous Sylius layout: <img width="1381" alt="image" src="https://user-images.githubusercontent.com/40125720/191003290-00b9d11c-5730-40ae-a0dc-ae7c11adf335.png"> Fixes: <img width="1077" alt="image" src="https://user-images.githubusercontent.com/40125720/191003706-335a3f6a-05b3-4474-8ced-3098f919259b.png"> Commits ------- 435fb07b0bb68358ba7abad2c61937b2243a4e4b [UI] removed important flag from the button class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refreshed Shop Theme
The idea was to refresh the Shop Theme, much like Admin Theme, editing mostly css files, minimally touching twigs
Home
Index
Show
Cart
Login