New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adblockers will block image paths containing 'ad' #9884

Closed
loevgaard opened this Issue Oct 30, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@loevgaard
Copy link
Contributor

loevgaard commented Oct 30, 2018

Sylius version affected: 1.*

Description
This issue is made from this forum thread: https://forum.sylius.com/t/adblockers-blocking-certain-images/672 so creds to William for figuring it out. I just wanted to add this issue before it was forgotten since it's quite important in my perspective.

Images are not displayed when the path contains ad.

Steps to reproduce
I haven't tried this myself, but a quick google search tells me the problem is evident: If you have certain ad blockers, images with paths containing ad will not be shown because the ad blocker believes it's an ad.

Possible Solution
The class handling file paths should check for the phrase ad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment