Fix select attributes according to recent Symfony form changes #10077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
the
Potential Bug
bartoszpietrzak1994
approved these changes
Jan 8, 2019
pamil
approved these changes
Jan 8, 2019
|
Thank you, Mateusz! 🎉 |
This was referenced Jan 11, 2019
Closed
pamil
added a commit
that referenced
this pull request
Feb 3, 2019
…rm changes (Zales0123) This PR was merged into the 1.1 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | related with #10077 | License | MIT Even though we don't support Sylius 1.1 yet, it would be nice to have the build passing 😄 This version should still get security fixes and it can be hard to determine if this security fix does not break anything if the build would be failing anyway 🔐 👁 Commits ------- 8cad15e [1.1] Fix select attributes according to recent Symfony form changes
pamil
added a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…rm changes (Zales0123) This PR was merged into the 1.2 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | related to symfony/symfony#29307 | License | MIT Due to the latest Symfony 4.1.10/3.4.21 release and changes introduced in linked PR, a bug in select attribute type araised 🌤 Apparently, possible to select values in attribute configuration was saved with `TextType` form type, even though `SelectAttributeValueTranslationsType` should be used. It was somehow parsed before, but know it's not possible and this PR fixes this absurdity 🖖 Commits ------- 51f7ec2 Fix select attributes according to recent Symfony form changes b80fa00 Fix test in ResourceBundle (taken from Sylius#10062)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the latest Symfony 4.1.10/3.4.21 release and changes introduced in linked PR, a bug in select attribute type araised 🌤 Apparently, possible to select values in attribute configuration was saved with
TextTypeform type, even thoughSelectAttributeValueTranslationsTypeshould be used. It was somehow parsed before, but know it's not possible and this PR fixes this absurdity 🖖