Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FriendsOfBehat\SymfonyExtension v2 #10102

merged 1 commit into from Jan 17, 2019

Use FriendsOfBehat\SymfonyExtension v2 #10102

merged 1 commit into from Jan 17, 2019


Copy link

@pamil pamil commented Jan 15, 2019

Branch? 1.4
Bug fix? no
New feature? no
BC breaks? no (Behat configuration, not covered by BC promise)
Deprecations? no
Related tickets related to #10056
License MIT

Behat configuration will change in 1.4, but we'll provide necessary upgrade instructions and configurations to use in plugins to achieve the smoothest adoption path as possible in another PRs.

@pamil pamil requested a review from Sylius/core-team as a code owner Jan 15, 2019
@pamil pamil mentioned this pull request Jan 15, 2019
3 of 4 tasks complete
@pamil pamil force-pushed the pamil:1.4-new-behat branch 3 times, most recently from 9263ca8 to dbc3f42 Jan 16, 2019
@pamil pamil force-pushed the pamil:1.4-new-behat branch from dbc3f42 to 708c5cd Jan 16, 2019

files_path: "%paths.base%/src/Sylius/Behat/Resources/fixtures/"
base_url: "http://localhost:8080/"

This comment has been minimized.


bartoszpietrzak1994 Jan 17, 2019

What does hardcoding the port mean for javascript-related scenarios when the server has to be running? Do we mention this in readme/docs? Or if not, is there a plan to do so?

This comment has been minimized.


pamil Jan 17, 2019
Author Member

AFAIK it is not mentioned there, but it's a change not connected to this PR (I've copied it from src/Sylius/Behat/Resources/config/suites/default.yml). I think that some docs would be welcome, though in Sylius-Standard 1.4 it would be copied to the default config file also.

@pamil pamil merged commit 0d149bd into Sylius:master Jan 17, 2019
2 checks passed
2 checks passed
WIP Ready for review
continuous-integration/travis-ci/pr The Travis CI build passed
@pamil pamil deleted the pamil:1.4-new-behat branch Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants