New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index on order.cart + order.updated_at for faster expired cart removal selection #10149

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
3 participants
@stefandoorn
Copy link
Contributor

stefandoorn commented Feb 4, 2019

Q A
Branch? 1.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets partially #10148
License MIT

Makes selection of expired carts way more efficient. Especially helpful in growing projects.

Before:

image

After:

image

@stefandoorn stefandoorn requested a review from Sylius/core-team as a code owner Feb 4, 2019

@lchrusciel lchrusciel changed the base branch from 1.2 to master Feb 6, 2019

@lchrusciel
Copy link
Member

lchrusciel left a comment

Thanks a lot, Stefan! However, I have changed branch to master, as it seems to be more like a feature, rather than bug. /cc @pamil

@pamil

pamil approved these changes Feb 6, 2019

@pamil pamil added the Feature label Feb 6, 2019

@pamil

This comment has been minimized.

Copy link
Member

pamil commented Feb 6, 2019

We only add new migrations in minor releases, so that you could update your patch version anytime and don't care about schema changes.

@pamil pamil merged commit 53f150f into Sylius:master Feb 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pamil

This comment has been minimized.

Copy link
Member

pamil commented Feb 6, 2019

Thanks, Stefan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment