Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an Administrator, I want always to have proper option values selected while editing a product variant #10364

Merged
merged 4 commits into from May 15, 2019

Conversation

@Tomanhez
Copy link
Member

commented May 8, 2019

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #8999, replaces #9223
License MIT
Tomanhez and others added 3 commits May 8, 2019
[ProductBundle] Fix default ProductOptionValue
Fix a bug in ProductOptionValueCollectionType where in the form generation were not taken in consideration the actual value of the option to show it as a default value.

@Tomanhez Tomanhez requested a review from Sylius/core-team as a code owner May 8, 2019

@Zales0123 Zales0123 added the Bug label May 8, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:editing-product-variant branch from f172353 to b50df40 May 8, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:editing-product-variant branch 3 times, most recently from 1363ce7 to bd05513 May 8, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:editing-product-variant branch from bd05513 to 6be2851 May 9, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:editing-product-variant branch from 56111e3 to 96550ef May 14, 2019

@GSadee
GSadee approved these changes May 14, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:editing-product-variant branch from 96550ef to 0498f9e May 15, 2019

@GSadee GSadee merged commit a157b58 into Sylius:1.3 May 15, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GSadee

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Thank you, Tomasz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.