Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin][Promotion] Fix removing taxon used in promotion rule #10365

Merged
merged 8 commits into from May 13, 2019

Conversation

@GSadee
Copy link
Member

commented May 8, 2019

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #10225
License MIT

Zrzut ekranu 2019-05-10 o 12 50 29

@GSadee GSadee requested a review from Sylius/core-team as a code owner May 8, 2019

@GSadee GSadee added the Bug label May 8, 2019

@GSadee GSadee force-pushed the GSadee:remove-taxon-used-in-promotion branch from 0a701f5 to b1732fa May 9, 2019

@GSadee GSadee force-pushed the GSadee:remove-taxon-used-in-promotion branch from b1732fa to 07d39f2 May 9, 2019

GSadee added 6 commits May 8, 2019

@GSadee GSadee force-pushed the GSadee:remove-taxon-used-in-promotion branch from dab9ee8 to 1e82d3c May 10, 2019

@GSadee GSadee force-pushed the GSadee:remove-taxon-used-in-promotion branch from e3164ab to ee6508a May 13, 2019

@GSadee GSadee force-pushed the GSadee:remove-taxon-used-in-promotion branch from ee6508a to 93cd924 May 13, 2019

'success' => 'positive',
];
Assert::keyExists($typeClassMap, $type->__toString());

This comment has been minimized.

Copy link
@lchrusciel

lchrusciel May 13, 2019

Member

I'm just wondering, what is better

Suggested change
Assert::keyExists($typeClassMap, $type->__toString());
Assert::keyExists($typeClassMap, (string) $type);

@lchrusciel lchrusciel merged commit 39c3f63 into Sylius:1.3 May 13, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lchrusciel

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Thank you, Grzegorz! 🥇

@GSadee GSadee deleted the GSadee:remove-taxon-used-in-promotion branch May 13, 2019

pamil added a commit that referenced this pull request May 15, 2019
bug #10386 [Build Fix][Behat] Change scenarios to @javascript due to …
…taxon tree changes (Zales0123)

This PR was merged into the 1.3 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.3
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | #10228, #10365
| License         | 

Commits
-------

e539ee0 [Behat] Change scenarios to @javascript due to taxon tree changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.