Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Add possibility to configure custom index route in routing #10451

Merged
merged 1 commit into from Jun 13, 2019

Conversation

@GSadee
Copy link
Member

commented Jun 13, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

It gives a possibility to configure:

your_route:
    ...
    defaults:
        ...
        _sylius:
            vars:
                ...
                index:
                    route:
                        name: custom_route
                        parameters: custom_parameters

@GSadee GSadee requested a review from Sylius/core-team as a code owner Jun 13, 2019

@Zales0123 Zales0123 added the Feature label Jun 13, 2019

@GSadee GSadee added the Admin label Jun 13, 2019

@pamil
pamil approved these changes Jun 13, 2019
@pamil

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Do we have any docs we could add the new configuration option to?

@CoderMaggie

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

@pamil It is a veeeeeery custom situation Grzegorz is covering here. I'd skip the documentation.

It happens if someone wants to override existing Sylius routing in order to use it for their custom entity or define different routing for index than for other actions. Let's say someone takes our Promotions routing but uses it to some kind of blog or cms entities (the only idea that came to my mind right now ;D).

@pamil pamil merged commit f1587df into Sylius:master Jun 13, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pamil

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Thanks, Grzegorz! 🎉

@GSadee GSadee deleted the GSadee:admin-crud-custom-index branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.