Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Promotion] Coupon prefix and suffix #10485

Merged
merged 7 commits into from Jul 3, 2019

Conversation

@Zales0123
Copy link
Member

commented Jul 1, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

Form:
Zrzut ekranu 2019-07-1 o 12 50 41

Generated coupons:
Zrzut ekranu 2019-07-1 o 12 59 35

Zales0123 added 6 commits Jul 1, 2019

@Zales0123 Zales0123 added the Feature label Jul 1, 2019

@Zales0123 Zales0123 requested review from CoderMaggie and Sylius/core-team Jul 1, 2019

@CoderMaggie

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Would be wonderful if we could add tooltips explaining what are these.
Moreover, I would improve the UX, by making the code length field shorter and the prefix/suffix fields with some placeholders I.e. 2019SALE_

@Zales0123

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

@CoderMaggie agreed 👍 However, as it's a UI/UX job, I would leave it as it is in this PR (to not make it longer than needed) and let somebody more experienced with front-end (probably @kulczy 😄) do the job 🚀

@Zales0123 Zales0123 force-pushed the Zales0123:coupon-prefix-and-suffix branch 3 times, most recently from 03161f5 to 91c35d6 Jul 2, 2019

@Zales0123 Zales0123 force-pushed the Zales0123:coupon-prefix-and-suffix branch from 91c35d6 to 1a5dcd2 Jul 2, 2019

@Zales0123 Zales0123 force-pushed the Zales0123:coupon-prefix-and-suffix branch from 1a5dcd2 to 9a24f0a Jul 2, 2019

@lchrusciel lchrusciel merged commit 4e06a4d into Sylius:master Jul 3, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lchrusciel

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Thank you, Mateusz! 🎉

@Zales0123 Zales0123 deleted the Zales0123:coupon-prefix-and-suffix branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.