Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixtures] Improve fixtures. #10529

Merged
merged 4 commits into from Jul 19, 2019

Conversation

@AdamKasp
Copy link
Member

commented Jul 17, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

Screenshot 2019-07-18 at 12 29 10
Screenshot 2019-07-18 at 12 30 27

todo:

  • fix prices
  • product name with the relevant photo
  • fix variant generate unnesessary picture
  • Taxes
  • Imrove Variants name

@AdamKasp AdamKasp requested a review from Sylius/core-team as a code owner Jul 17, 2019

@AdamKasp AdamKasp changed the title Improve fixtures. [Fixtures] Improve fixtures. Jul 17, 2019

@AdamKasp AdamKasp force-pushed the AdamKasp:improve-product-fixtures branch 4 times, most recently from ceea68a to 39cc9d7 Jul 18, 2019

AdamKasp added 3 commits Jul 17, 2019

@AdamKasp AdamKasp force-pushed the AdamKasp:improve-product-fixtures branch from e032eef to 6ed4ffa Jul 18, 2019

@@ -106,7 +106,7 @@ protected function configureOptionsNode(ArrayNodeDefinition $optionsNode): void
private function getAssociatedProductsAsArray(ProductInterface $owner): array
{
$products = $this->productRepository->findBy(['mainTaxon' => $owner->getMainTaxon()]);
$products = $this->faker->randomElements($products, 3);
$products = $this->faker->randomElements($products, 2);

This comment has been minimized.

Copy link
@lchrusciel

@lchrusciel lchrusciel merged commit df295e4 into Sylius:master Jul 19, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lchrusciel

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Thanks, Adam! 🎉

lchrusciel added a commit that referenced this pull request Jul 22, 2019
feature #10539 [Fixtures] Add tax category to product. (AdamKasp)
This PR was merged into the 1.6-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | based on: #10529 
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.4 or 1.5 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set
-->
![Screenshot 2019-07-19 at 10 06 18](https://user-images.githubusercontent.com/29897151/61519721-e633e180-aa0c-11e9-9aef-fb2a40e5cb4a.png)


Commits
-------

de0b665 Added tax category to product fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.