Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle] Uncoupled AdminBundle with ShopBundle #10614

Merged

Conversation

@Tomanhez
Copy link
Member

commented Aug 23, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Fix: #10607

ProductShowPage after ShopBundle excluded:

Screenshot 2019-08-23 at 14 42 38

@Tomanhez Tomanhez requested a review from Sylius/core-team as a code owner Aug 23, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:uncoupled-adminbundle-with-shopbundle branch from 2e15057 to 4c8750d Aug 23, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:uncoupled-adminbundle-with-shopbundle branch from 4c8750d to 1384014 Aug 23, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:uncoupled-adminbundle-with-shopbundle branch from 1384014 to 0f6b868 Aug 23, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:uncoupled-adminbundle-with-shopbundle branch from 2201eb9 to 84afeec Aug 23, 2019

docs/cookbook/images/images.rst Outdated Show resolved Hide resolved

@Zales0123 Zales0123 added the Bug label Aug 23, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:uncoupled-adminbundle-with-shopbundle branch from 84afeec to eef5a90 Aug 23, 2019

@pamil
pamil approved these changes Aug 23, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:uncoupled-adminbundle-with-shopbundle branch from eef5a90 to 07122b4 Aug 26, 2019

Tomanhez added 3 commits Aug 23, 2019

@Tomanhez Tomanhez force-pushed the Tomanhez:uncoupled-adminbundle-with-shopbundle branch from 07122b4 to de8a7f5 Aug 26, 2019

@lchrusciel lchrusciel merged commit b6be573 into Sylius:master Aug 26, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lchrusciel

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Thank you, Tomasz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.