Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP of the debug cart panel #10688

Merged
merged 2 commits into from May 20, 2020
Merged

MVP of the debug cart panel #10688

merged 2 commits into from May 20, 2020

Conversation

pjedrzejewski
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

Why? Sometimes, you want to debug what was inside of the cart on a specific request. While on shop pages you will see the cart summary widget, you do not know the details (id, ids and codes of products/variants), etc. This is useful when debugging promotions, taxes, etc. This is an MVP done during a hackathon, but can be extended with more data and details, especially about $.

Screenshot 2019-09-21 at 16 54 08

Screenshot 2019-09-21 at 16 54 11

Sylius___Your_shopping_cart

@pjedrzejewski pjedrzejewski requested a review from a team as a code owner September 21, 2019 14:59
@pjedrzejewski pjedrzejewski added the DX Issues and PRs aimed at improving Developer eXperience. label Sep 21, 2019
@stale
Copy link

stale bot commented Dec 20, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Dec 20, 2019
@stale stale bot closed this Dec 27, 2019
@gabiudrescu
Copy link
Contributor

I wouldn't leave this gem to get lost

@lchrusciel lchrusciel reopened this Jan 8, 2020
@stale stale bot removed the Stale Issues and PRs with no recent activity, about to be closed soon. label Jan 8, 2020
@gabiudrescu
Copy link
Contributor

I would add to this debug panel for cart the promotions that were evaluated for eligibility and why they were rejected or not. With the current implementation, it takes a lot of concentration to understand why a promotion was applied to cart or why it didn't.

and if you have a couple of hundred of them... things can get really really messy.

@lchrusciel lchrusciel added the Do not stale Important issues and PRs, that should not be stalled by Stale Bot label Jan 13, 2020
@pamil
Copy link
Contributor

pamil commented May 20, 2020

Added an icon for the cart:

CleanShot 2020-05-20 at 19 37 28@2x

CleanShot 2020-05-20 at 19 37 17@2x

@lchrusciel lchrusciel merged commit 552c4a0 into Sylius:master May 20, 2020
@lchrusciel
Copy link
Member

Thanks, Paweł! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not stale Important issues and PRs, that should not be stalled by Stale Bot DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants