Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate attribute type on attributes grid #10752

Merged
merged 3 commits into from Oct 10, 2019

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Oct 9, 2019

Q A
Branch? 1.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner October 9, 2019 10:18
@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Oct 10, 2019
@pamil pamil force-pushed the fix/translate-attribute-type branch from 9269580 to a81ef2f Compare October 10, 2019 16:16
@pamil pamil changed the base branch from 1.4 to 1.5 October 10, 2019 16:16
@pamil
Copy link
Contributor

pamil commented Oct 10, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "fix/translate-attribute-type" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil merged commit ffd6df6 into Sylius:1.5 Oct 10, 2019
@pamil
Copy link
Contributor

pamil commented Oct 10, 2019

Thank you, Loïc! 🥇

@loic425 loic425 deleted the fix/translate-attribute-type branch October 11, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants