Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint:container command to the build & fix errors reported by it #10926

Merged
merged 3 commits into from Dec 11, 2019

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Dec 11, 2019

Q A
Branch? 1.5
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

Removes services defined for nonexisting classes and fixes other container-related errors.
Adds lint:container command to the build.

https://symfony.com/blog/new-in-symfony-4-4-service-container-linter

@pamil pamil requested a review from as a code owner Dec 11, 2019
@pamil pamil changed the title | Q | A | --------------- | ----- | Branch? | 1.5 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | - | License | MIT Add lint:container command to the build & fix errors reported by it Dec 11, 2019
@pamil pamil added Potential Bug Enhancement Maintenance labels Dec 11, 2019
@lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Dec 11, 2019

Fixes: #10866

@lchrusciel lchrusciel merged commit 3bf7ac4 into Sylius:1.5 Dec 11, 2019
3 checks passed
@lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Dec 11, 2019

Thanks, Kamil! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Maintenance Potential Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants