Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Fix Refund Process Cookbook #12702

Merged
merged 2 commits into from Jun 9, 2021
Merged

[Documentation] Fix Refund Process Cookbook #12702

merged 2 commits into from Jun 9, 2021

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Jun 9, 2021

Q A
Branch? 1.9
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets after #12686
License MIT

@GSadee GSadee added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jun 9, 2021
@GSadee GSadee requested a review from a team as a code owner June 9, 2021 05:41
@GSadee GSadee changed the base branch from master to 1.9 June 9, 2021 05:41
arti0090
arti0090 approved these changes Jun 9, 2021
View reviewed changes
docs/cookbook/index.rst
.. toctree::
:hidden:

refund/refund-process.rst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am a bit concerned that payments will mix up with refunds in this case, but still customers can use search and find what they are looking for (very low priority comment imo) 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to be consistent with our current docs structure, where we have cookbook for customizing Credit Memo in Paymets section, IMO these two cookbooks should belong to the same section

@Zales0123 Zales0123 merged commit 3540f17 into Sylius:1.9 Jun 9, 2021
@Zales0123
Copy link
Member

Thanks, Grzegorz! 🥇

@GSadee GSadee deleted the fix-refund-process-cookbook branch June 9, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@arti0090 arti0090 arti0090 approved these changes

@Tomanhez Tomanhez Tomanhez approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GSadee @Zales0123 @arti0090 @Tomanhez