Fixed user reset events #3184
Merged
Fixed user reset events #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is throwing an error on search test, I will have a look this evening. |
| * This event allows you to set the response instead of using the default one. | ||
| * The event listener method receives a Symfony\Component\EventDispatcher\GenericEvent instance. | ||
| */ | ||
| const PRE_PASSWORD_CHANGE = 'sylius.user.password_change.pre'; |
There was a problem hiding this comment.
Missing blank line after this.
|
@gonzalovilaseca Thanks man! I restarted the build - we need to track down the random bug with search... Please have a look at my comments. |
|
PR updated, once it's ready to merge I'll rebase it. |
michalmarcinkowski
added a commit
that referenced
this pull request
Aug 28, 2015
Fixed user reset events
|
Great! Thank you Gonzalo! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info about this PR here: #3167
I'm happy to change the events description if anyone has better ideas.