New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Loosely couple with Shop in case of customer impersonation #8474

Merged
merged 2 commits into from Aug 31, 2017

Conversation

Projects
None yet
4 participants
@Zales0123
Member

Zales0123 commented Aug 28, 2017

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related tickets fixes #8271
License MIT
@pamil

pamil approved these changes Aug 30, 2017

@lchrusciel

Just an idea for further improvements. Can't we introduce sonata block where the button should be added and then just inject button in that place? We would remove this additional parameter and also everything related to the impersonator would be defined in same service file

@pjedrzejewski pjedrzejewski merged commit fbb5020 into Sylius:master Aug 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pjedrzejewski

This comment has been minimized.

Show comment
Hide comment
@pjedrzejewski

pjedrzejewski Aug 31, 2017

Member

Thank you Mateusz!

@lchrusciel Good idea for later! 👍

Member

pjedrzejewski commented Aug 31, 2017

Thank you Mateusz!

@lchrusciel Good idea for later! 👍

@Zales0123 Zales0123 deleted the Zales0123:loosely-couple-admin-with-shop branch Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment