New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base URL support in ThemeBundle (fixes #8278) #8556

Merged
merged 2 commits into from Sep 9, 2017

Conversation

Projects
None yet
3 participants
@stefandoorn
Contributor

stefandoorn commented Sep 8, 2017

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Related tickets fixes #8278
License MIT

Overrides Symfony's UrlPackage to allow theme bundle to handle different base URL's. Allows users that use themes, also to use CDN base URL's for assets.

@stefandoorn stefandoorn changed the title from [WIP] Base URL support in ThemeBundle (fixes #8278) to Base URL support in ThemeBundle (fixes #8278) Sep 8, 2017

Begin with base url support in ThemeBundle
Fix spec

Fix specs

Fix spec

Last changes

Improvements
@pamil

pamil approved these changes Sep 9, 2017

Show outdated Hide outdated src/Sylius/Bundle/ThemeBundle/Asset/Package/UrlPackage.php
$this->beConstructedWith(['https://cdn-url.com/'], $versionStrategy, $themeContext, $urlResolver);
}
function it_implements_package_interface(): void

This comment has been minimized.

@pamil

pamil Sep 9, 2017

Member

We might also add it_extends_symfony_url_package spec.

@pamil

pamil Sep 9, 2017

Member

We might also add it_extends_symfony_url_package spec.

This comment has been minimized.

@stefandoorn

stefandoorn Sep 9, 2017

Contributor

Added.

@stefandoorn

stefandoorn Sep 9, 2017

Contributor

Added.

Show outdated Hide outdated src/Sylius/Bundle/ThemeBundle/spec/Asset/Package/UrlPackageSpec.php
Show outdated Hide outdated src/Sylius/Bundle/ThemeBundle/Asset/Package/UrlPackage.php

@pamil pamil merged commit a0e3b21 into Sylius:master Sep 9, 2017

2 checks passed

Scrutinizer 1 new issues, 4 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Sep 9, 2017

Member

Thanks Stefan! 🎉

Member

pamil commented Sep 9, 2017

Thanks Stefan! 🎉

@pjedrzejewski

This comment has been minimized.

Show comment
Hide comment
@pjedrzejewski

pjedrzejewski Sep 10, 2017

Member

You rock Stefan, this is huge help before release, thanks!

Member

pjedrzejewski commented Sep 10, 2017

You rock Stefan, this is huge help before release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment