New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce coding standard #8634

Merged
merged 2 commits into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@pamil
Member

pamil commented Sep 12, 2017

Q A
Bug fix? kinda
New feature? no
BC breaks? no
Related tickets -
License MIT

@pamil pamil added the DX label Sep 12, 2017

@pamil pamil added this to the v1.0.0 milestone Sep 12, 2017

@pamil pamil self-assigned this Sep 12, 2017

pamil added some commits Sep 12, 2017

@pjedrzejewski pjedrzejewski merged commit 0205d4b into Sylius:master Sep 12, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pjedrzejewski

This comment has been minimized.

Show comment
Hide comment
@pjedrzejewski

pjedrzejewski Sep 12, 2017

Member

Thanks Kamil!

Member

pjedrzejewski commented Sep 12, 2017

Thanks Kamil!

@pamil pamil deleted the pamil:coding-style-checks branch Sep 12, 2017

@TomasVotruba

This comment has been minimized.

Show comment
Hide comment
@TomasVotruba

TomasVotruba Oct 8, 2017

Contributor

Thanks @pamil for adding this!

Let me know if you have any troubles with ECS. Just create issue here


Just a TIP: ECS is bundled with these 2 coding standards:

So you can use any Sniff/Fixer from them right away

E.g. TypeHintDeclaration one of the most powerful addition for PHP 7 projects

Contributor

TomasVotruba commented Oct 8, 2017

Thanks @pamil for adding this!

Let me know if you have any troubles with ECS. Just create issue here


Just a TIP: ECS is bundled with these 2 coding standards:

So you can use any Sniff/Fixer from them right away

E.g. TypeHintDeclaration one of the most powerful addition for PHP 7 projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment