Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitignore webserver pid files #8682

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Gitignore webserver pid files #8682

merged 1 commit into from
Sep 18, 2017

Conversation

gabiudrescu
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Related tickets fixes #8681
License MIT

@lchrusciel lchrusciel merged commit 7bb1afd into Sylius:master Sep 18, 2017
@lchrusciel
Copy link
Member

Thanks Gabi! 👍

@pamil pamil added the Bug Fix label Sep 18, 2017
@pamil
Copy link
Contributor

pamil commented Sep 18, 2017

It should rather get merged to 1.0 branch :/

@gabiudrescu
Copy link
Contributor Author

@pamil how do you plan to handle git flow, now that 1.0 was tagged?

@lchrusciel
Copy link
Member

Sorry, my bad. Should I cherry-pick it to 1.0 or you want to do it?

@gabiudrescu
Copy link
Contributor Author

@lchrusciel my git-fu goes only this far: #8686

@lchrusciel
Copy link
Member

@gabiudrescu we will handle it. If we would merge your PR there could be some conflicts. I just forgot to change the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve gitignore by ignoring webserver pid files
3 participants
@gabiudrescu @lchrusciel @pamil