GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Based on the PR #8206 created by @Lowlo and partially based on the PR #8751
Hmm, is there any way we can get rid of those parent calls?
I've been trying to come up with better solution, but without success. If you have any suggestion, please share with me 😃
Add select attribute translation
[Behat][ProductAttribute] Add scenarios for deleting choice value of …
…a select product attribute
[Behat][ProductAttribute] Add and implement scenarios for viewing sel…
…ect attributes in different locales
[ProductAttribute] Fixes to translatable select product attribute
[Migrations][ProductAttribute] Refactor migrations for translatable s…
…elect product attribute
[Fixtures][ProductAttribute] Update fixtures
[ProductAttribute] Update behat and phpunit tests
Fixes after rebase
I guess there's still something wrong with those definitions, %locale% points to a base locale code, whereas sylius.translation_locale_provider service has getDefaultLocaleCode method which returns current channel's default locale. Is there any reason for using these two simultaneously instead of only one of them?
I didn't notice that 👍
I've changed to use sylius.translation_locale_provider instead of %locale%.
[Attribute] Fixes after PR review
Thanks @Lowlo & @GSadee, especially for your patience! :)