New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility promise #8901

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
5 participants
@pamil
Member

pamil commented Oct 25, 2017

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets related to #8748
License MIT

@pamil pamil added the Documentation label Oct 25, 2017

@pamil pamil added this to the 1.0 milestone Oct 25, 2017

@pamil pamil self-assigned this Oct 25, 2017

Code covered
------------
This BC promise applies to all of Sylius' PHP code except for:

This comment has been minimized.

@GSadee

GSadee Oct 25, 2017

Member

Maybe js files should be added to this list?

@GSadee

GSadee Oct 25, 2017

Member

Maybe js files should be added to this list?

This comment has been minimized.

@pamil

pamil Oct 25, 2017

Member

JS files aren't PHP code 🎉

@pamil

pamil Oct 25, 2017

Member

JS files aren't PHP code 🎉

@GSadee

GSadee approved these changes Oct 26, 2017

@GSadee GSadee referenced this pull request Oct 27, 2017

Merged

Product reviews API #8772

@pjedrzejewski pjedrzejewski merged commit ac34193 into Sylius:1.0 Oct 27, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pjedrzejewski

This comment has been minimized.

Show comment
Hide comment
@pjedrzejewski

pjedrzejewski Oct 27, 2017

Member

Thank you Kamil, nice work! 👍

Member

pjedrzejewski commented Oct 27, 2017

Thank you Kamil, nice work! 👍

@pamil pamil deleted the pamil:1.0-bc-promise branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment