New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI form add button issue collection in a collection #9097

Merged
merged 1 commit into from Jan 12, 2018

Conversation

Projects
None yet
3 participants
@wadjeroudi
Contributor

wadjeroudi commented Jan 10, 2018

If you have a collection in a collection in an admin form for example, it should take the last add button not the first.
If you take the first, it will take the first of the first embedded collection if you have one (not the right one).

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT
Fix UI form add button issue collection in a collection
If you have a collection in a collection in an admin form for example, it should take the last add button not the first.
If you take the first, it will take the first of the first embedded collection if you have one (not the right one).
@wadjeroudi

This comment has been minimized.

Show comment
Hide comment
@wadjeroudi

wadjeroudi Jan 11, 2018

Contributor

@pjedrzejewski @lchrusciel @pamil is the travis ui suite test correct on 1.0 ?

Contributor

wadjeroudi commented Jan 11, 2018

@pjedrzejewski @lchrusciel @pamil is the travis ui suite test correct on 1.0 ?

@lchrusciel

This comment has been minimized.

Show comment
Hide comment
@lchrusciel

lchrusciel Jan 12, 2018

Member

From time to time builds can randomly fail. I've restarted your build

Member

lchrusciel commented Jan 12, 2018

From time to time builds can randomly fail. I've restarted your build

@pamil

pamil approved these changes Jan 12, 2018

@pamil pamil merged commit 99fe673 into Sylius:1.0 Jan 12, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Jan 12, 2018

Member

Thanks @wadjeroudi! 🎉

Member

pamil commented Jan 12, 2018

Thanks @wadjeroudi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment