New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong target-entity in exchange-rate entity #9101

Merged
merged 1 commit into from Jan 12, 2018

Conversation

Projects
None yet
2 participants
@alcaeus
Contributor

alcaeus commented Jan 12, 2018

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

This fixes an error that surfaces when trying to extend the Currency entity: due to the wrong mapping, it's not actually possible to extend the Currency entity.

I'm not sure how to reliably test this, apart from looking at all 97 target-entity attributes and ensuring they point to interfaces (except a Payum GatewayConfig that doesn't have an interface).

@pamil

pamil approved these changes Jan 12, 2018

@pamil pamil merged commit a95ecc2 into Sylius:1.0 Jan 12, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Jan 12, 2018

Member

Thank you Andreas! 🥇

Member

pamil commented Jan 12, 2018

Thank you Andreas! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment