New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SyliusShopBundle form theme #9786

Merged
merged 2 commits into from Oct 6, 2018

Conversation

Projects
None yet
3 participants
@maximehuran
Contributor

maximehuran commented Oct 5, 2018

Adding a form theme to ShopBundle

I created the file Form/theme.html.twig in SyliusShopBundle in order to be able to override this template in theme and only impact the front. With that, we can customize our shop without break the admin render.

Change UiBundle calls in ShopBundle

I changed the form theme called in SyliusShopBundle templates in order to call the created file.

Want to know more ?

See the Slack conversation

Thank you for your amazing work on Sylius 馃殌
If you want more information, ask me 馃憖

@maximehuran maximehuran requested a review from Sylius/core-team as a code owner Oct 5, 2018

maximehuran added some commits Oct 5, 2018

@lchrusciel

Thanks for the contribution!

Can you do same for admin panel?

@@ -0,0 +1 @@
{% extends '@SyliusUi/Form/theme.html.twig' %}

This comment has been minimized.

@lchrusciel

lchrusciel Oct 6, 2018

Member

Missing newline after this one

@lchrusciel

lchrusciel Oct 6, 2018

Member

Missing newline after this one

@pamil

pamil approved these changes Oct 6, 2018

@pamil pamil merged commit 3d5e445 into Sylius:master Oct 6, 2018

2 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pamil

This comment has been minimized.

Show comment
Hide comment
@pamil

pamil Oct 6, 2018

Member

Thank you, Maxime! 馃

Member

pamil commented Oct 6, 2018

Thank you, Maxime! 馃

@maximehuran maximehuran deleted the maximehuran:feature/sylius-shop-form-theme branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment