Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution guide #597

Open
towoe opened this issue Jan 31, 2020 · 0 comments
Open

Contribution guide #597

towoe opened this issue Jan 31, 2020 · 0 comments
Assignees
Labels

Comments

@towoe
Copy link
Contributor

@towoe towoe commented Jan 31, 2020

It would be nice to have some guidelines as to how to contribute properly.
I just started a PR and had to update the commits a few times in order to pass the checks.

Some description about the rules would be helpful to make the contribution process easier.
What I discovered so far:

  • "Signed-off-by" line is required for the commit
  • run make format
@hzeller hzeller self-assigned this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.