Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for cores outside of riscv-formal repository #11

Open
wants to merge 1 commit into
base: master
from

Conversation

@stevehoover
Copy link

@stevehoover stevehoover commented Sep 20, 2018

Hey, Clifford! I've incorporated riscv-formal runs into my WARP-V CI testing. These changes will help me clean up the process a bit. They let me run with riscv-formal as a submodule in the warp-v repo. All they do is make 'basedir' in genchecks configurable. Be aware that I'm new to Python.

I'm not sure how you would prefer to handle pull requests. I don't see a regression test, per se, but I ran pico and Vex with and without the change and got the same errors both ways :).

Sorry about my timing. I'm sure you are busy preparing for ORConf. I hope it goes well!

@@ -26,16 +26,36 @@
blackbox = False

cfgname = "checks"
basedir = "%s/../.." % os.getcwd()
basedir = "../.." # Assuming run from within riscv-formal/cores/<core>. Relative path for now.

This comment has been minimized.

@cliffordwolf

cliffordwolf Nov 5, 2018
Collaborator

This will break existing cores. The "run from within riscv-formal/cores/<core>" assumption is bogus. There are different tools being run in different directories (for example most checks are run in riscv-formal/cores/<core>/checks) that all inherit this basedir string. It must be an absolute path.

This comment has been minimized.

@stevehoover

stevehoover Dec 20, 2018
Author

Finally getting back to this. It looks like I was allowing the --basedir argument to be a relative path, in which case I append os.getcwd() after arg processing. Thus prepending os.getcwd() on line 29 isn't necessary as it will happen below. If you'd prefer to keep line 29 as it was, I can put another pull request together.

@cliffordwolf cliffordwolf self-assigned this Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants