Added support for cores outside of riscv-formal repository #11
Conversation
…--basedir arg to genchecks.py.
| @@ -26,16 +26,36 @@ | |||
| blackbox = False | |||
|
|
|||
| cfgname = "checks" | |||
| basedir = "%s/../.." % os.getcwd() | |||
| basedir = "../.." # Assuming run from within riscv-formal/cores/<core>. Relative path for now. | |||
cliffordwolf
Nov 5, 2018
•
Collaborator
This will break existing cores. The "run from within riscv-formal/cores/<core>" assumption is bogus. There are different tools being run in different directories (for example most checks are run in riscv-formal/cores/<core>/checks) that all inherit this basedir string. It must be an absolute path.
This will break existing cores. The "run from within riscv-formal/cores/<core>" assumption is bogus. There are different tools being run in different directories (for example most checks are run in riscv-formal/cores/<core>/checks) that all inherit this basedir string. It must be an absolute path.
stevehoover
Dec 20, 2018
Author
Finally getting back to this. It looks like I was allowing the --basedir argument to be a relative path, in which case I append os.getcwd() after arg processing. Thus prepending os.getcwd() on line 29 isn't necessary as it will happen below. If you'd prefer to keep line 29 as it was, I can put another pull request together.
Finally getting back to this. It looks like I was allowing the --basedir argument to be a relative path, in which case I append os.getcwd() after arg processing. Thus prepending os.getcwd() on line 29 isn't necessary as it will happen below. If you'd prefer to keep line 29 as it was, I can put another pull request together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hey, Clifford! I've incorporated riscv-formal runs into my WARP-V CI testing. These changes will help me clean up the process a bit. They let me run with riscv-formal as a submodule in the warp-v repo. All they do is make 'basedir' in genchecks configurable. Be aware that I'm new to Python.
I'm not sure how you would prefer to handle pull requests. I don't see a regression test, per se, but I ran pico and Vex with and without the change and got the same errors both ways :).
Sorry about my timing. I'm sure you are busy preparing for ORConf. I hope it goes well!