Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for cores outside of riscv-formal repository #11
base: master
Added support for cores outside of riscv-formal repository #11
Changes from all commits
8071235File filter...
Jump to…
Added support for cores outside of riscv-formal repository by adding …
cliffordwolfNov 5, 2018
•
edited
Collaborator
This will break existing cores. The "run from within
riscv-formal/cores/<core>" assumption is bogus. There are different tools being run in different directories (for example most checks are run inriscv-formal/cores/<core>/checks) that all inherit this basedir string. It must be an absolute path.stevehooverDec 20, 2018
Author
Finally getting back to this. It looks like I was allowing the --basedir argument to be a relative path, in which case I append os.getcwd() after arg processing. Thus prepending os.getcwd() on line 29 isn't necessary as it will happen below. If you'd prefer to keep line 29 as it was, I can put another pull request together.